-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(PZ-5662): E2E tests and detail page #2778
Conversation
@DaxRiool Not a big issue but your branch name does not correspond with our conventions. :-) See: https://dimpact.atlassian.net/wiki/spaces/PZW/pages/4523355/Git+Trunk-based+Development+Strategy
We can of course also change our convention if desired. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
in future we should probably use the generated types for RestTaak and RestZaak but that's for another story :-)
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #2778 +/- ##
============================================
- Coverage 42.17% 42.16% -0.02%
Complexity 3476 3476
============================================
Files 1336 1336
Lines 32268 32271 +3
Branches 3042 3045 +3
============================================
- Hits 13610 13608 -2
- Misses 17435 17440 +5
Partials 1223 1223
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
These changes will solve the problems we are currently having on the detail page of a zaak
Solves PZ-5562