Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PZ-5662): E2E tests and detail page #2778

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

DaxRiool
Copy link
Collaborator

These changes will solve the problems we are currently having on the detail page of a zaak

Solves PZ-5562

@DaxRiool DaxRiool requested review from hsiliev and a team as code owners February 26, 2025 13:11
@DaxRiool DaxRiool changed the title Fix/PZ-5662-E2E-Tests/Detail-Page fix(PZ-5662): E2E tests and detail page Feb 26, 2025
@edgarvonk
Copy link
Member

edgarvonk commented Feb 26, 2025

@DaxRiool Not a big issue but your branch name does not correspond with our conventions. :-) See: https://dimpact.atlassian.net/wiki/spaces/PZW/pages/4523355/Git+Trunk-based+Development+Strategy

feature/PZ-XXX-some-description

We can of course also change our convention if desired.

Copy link
Member

@edgarvonk edgarvonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

in future we should probably use the generated types for RestTaak and RestZaak but that's for another story :-)

@xiduzo xiduzo enabled auto-merge February 26, 2025 13:25
Copy link
Contributor

unit-test-results

 85 files  ±0  123 suites  ±0   1m 42s ⏱️ -1s
474 tests ±0  473 ✅ ±0  1 💤 ±0  0 ❌ ±0 
577 runs  ±0  575 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 88ff0f6. ± Comparison against base commit 4241ffe.

Copy link
Contributor

integration-test-results

 31 files  ±0   31 suites  ±0   40s ⏱️ ±0s
114 tests ±0  114 ✅ ±0  0 💤 ±0  0 ❌ ±0 
127 runs  ±0  127 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 88ff0f6. ± Comparison against base commit 4241ffe.

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 42.16%. Comparing base (4241ffe) to head (88ff0f6).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...app/src/app/taken/taak-view/taak-view.component.ts 0.00% 2 Missing ⚠️
...app/src/app/zaken/zaak-view/zaak-view.component.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2778      +/-   ##
============================================
- Coverage     42.17%   42.16%   -0.02%     
  Complexity     3476     3476              
============================================
  Files          1336     1336              
  Lines         32268    32271       +3     
  Branches       3042     3045       +3     
============================================
- Hits          13610    13608       -2     
- Misses        17435    17440       +5     
  Partials       1223     1223              
Flag Coverage Δ
integrationtests 51.38% <ø> (-0.02%) ⬇️
unittests 28.14% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiduzo xiduzo added this pull request to the merge queue Feb 26, 2025
Merged via the queue into main with commit 22202da Feb 26, 2025
19 of 21 checks passed
@xiduzo xiduzo deleted the Fix/PZ-5662--FE-fix-e2e-tests/zaak-detail-page branch February 26, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants